[PATCH] D19236: Add DITypeIndex for CodeView and emit it for locals

Wed Apr 27 15:30:37 PDT 2016

On Wed, Apr 27, 2016 at 12:48 PM, Reid Kleckner via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> rnk added a comment.
>
> In http://reviews.llvm.org/D19236#414087, @dblaikie wrote:
>
> > Generally looks good - should there be more test coverage, though? At
> least testing one case of a type other than int being generated into the
> code view? (to demonstrate the new codepath, etc - it looks like the only
> things testing the CodeView type reference emission are testing the old
> "everything is int" implementation?)
>
>
> Yeah, the linker test case has some non-int variables, so I felt covered,
> but it doesn't actually emit indices to an object file. I changed
> local-variable.ll to have some 'unsigned' variables so now that's covered.
>

Yep - thanks!

>
>
> http://reviews.llvm.org/D19236
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160427/95d30cd8/attachment.html>