[PATCH] D19631: Debug Info: Restore the pre-r240853 behavior for DWARF2 bitfields.

[Adrian Prantl via llvm-commits]

aprantl created this revision.
aprantl added reviewers: echristo, dblaikie, probinson.
aprantl added subscribers: clayborg, llvm-commits.
aprantl set the repository for this revision to rL LLVM.
Herald added a subscriber: joker.eph.

The DWARF2 specification of DW_AT_bit_offset is ambiguous for
little-endian machines, but by restoring to the old behavior
we match what debuggers expect and what other popular compilers
generate.


Repository:
  rL LLVM

http://reviews.llvm.org/D19631

Files:
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  test/DebugInfo/ARM/bitfield.ll

Index: test/DebugInfo/ARM/bitfield.ll
===================================================================
--- test/DebugInfo/ARM/bitfield.ll
+++ test/DebugInfo/ARM/bitfield.ll
@@ -13,7 +13,7 @@
 ; CHECK:          DW_AT_name {{.*}} "reserved"
 ; CHECK:          DW_AT_byte_size  {{.*}} (0x04)
 ; CHECK:          DW_AT_bit_size   {{.*}} (0x1c)
-; CHECK:          DW_AT_bit_offset {{.*}} (0x18)
+; CHECK:          DW_AT_bit_offset {{.*}} (0xfffffffffffffff8)
 ; CHECK:          DW_AT_data_member_location {{.*}}00
 target datalayout = "e-m:o-p:32:32-f64:32:64-v64:32:64-v128:32:128-a:0:32-n32-S32"
 target triple = "thumbv7-apple-ios"
Index: lib/CodeGen/AsmPrinter/DwarfUnit.cpp
===================================================================
--- lib/CodeGen/AsmPrinter/DwarfUnit.cpp
+++ lib/CodeGen/AsmPrinter/DwarfUnit.cpp
@@ -1407,30 +1407,16 @@
       if (DD->getDwarfVersion() >= 4)
         addUInt(MemberDie, dwarf::DW_AT_data_bit_offset, None, Offset);
       else {
-        //
-        // The DWARF 2 DW_AT_bit_offset is counting the bits between the most
-        // significant bit of the aligned storage unit containing the bit field
-        // to
-        // the most significan bit of the bit field.
-        //
-        // Struct      Align       Align       Align
-        // v           v           v           v
-        // +-----------+-----*-----+-----*-----+--
-        // | ...             |b1|b2|b3|b4|
-        // +-----------+-----*-----+-----*-----+--
-        // |           |     |<-- Size ->|     |
-        // |<---- Offset --->|           |<--->|
-        // |           |     |              \_ DW_AT_bit_offset (little endian)
-        // |           |<--->|
-        // |<--------->|  \_ StartBitOffset = DW_AT_bit_offset (big endian)
-        //     \                            = DW_AT_data_bit_offset (biendian)
-        //      \_ OffsetInBytes
-        // The endian-dependent DWARF 2 offset.
-        uint64_t DwarfBitOffset = Asm->getDataLayout().isLittleEndian()
-                                      ? OffsetToAlignment(Offset + Size, Align)
-                                      : StartBitOffset;
-
-        addUInt(MemberDie, dwarf::DW_AT_bit_offset, None, DwarfBitOffset);
+        uint64_t HiMark = (Offset + FieldSize) & AlignMask;
+        uint64_t FieldOffset = (HiMark - FieldSize);
+        Offset -= FieldOffset;
+
+        // Maybe we need to work from the other end.
+        if (Asm->getDataLayout().isLittleEndian())
+          Offset = FieldSize - (Offset + Size);
+
+        addUInt(MemberDie, dwarf::DW_AT_bit_offset, None, Offset);
+        OffsetInBytes = FieldOffset >> 3;
       }
     } else
       // This is not a bitfield.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19631.55334.patch
Type: text/x-patch
Size: 2695 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160427/58d76e9b/attachment.bin>