[PATCH] D19616: tests/test_suite: Do not hide commandlines

[Matthias Braun via llvm-commits]

MatzeB created this revision.
MatzeB added reviewers: cmatthews, kristof.beyls.
MatzeB added a subscriber: llvm-commits.
MatzeB set the repository for this revision to rL LLVM.
Herald added a subscriber: mcrosier.

Remove the concept of a verbose mode. It was hiding the interesting information of
how cmake and lit were invoked (while we have no problem spamming the user with the full make and lit outputs).

Repository:
  rL LLVM

http://reviews.llvm.org/D19616

Files:
  lnt/tests/test_suite.py

Index: lnt/tests/test_suite.py
===================================================================
--- lnt/tests/test_suite.py
+++ lnt/tests/test_suite.py
@@ -190,9 +190,6 @@
                          help=("whether the autosubmit result should be committed "
                                "[%default]"),
                          type=int, default=True)
-        group.add_option("-v", "--verbose", dest="verbose",
-                         help="show verbose test results",
-                         action="store_true", default=False)
         group.add_option("", "--succinct-compile-output",
                          help="run Make without VERBOSE=1",
                          action="store_true", dest="succinct")
@@ -408,10 +405,9 @@
         return self.opts.threads
 
     def _check_call(self, *args, **kwargs):
-        if self.opts.verbose:
-            note('Execute: %s' % ' '.join(args[0]))
-            if 'cwd' in kwargs:
-                note('          (In %s)' % kwargs['cwd'])
+        note('Execute: %s' % ' '.join(args[0]))
+        if 'cwd' in kwargs:
+            note('          (In %s)' % kwargs['cwd'])
         return subprocess.check_call(*args, **kwargs)
     
     def _clean(self, path):


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19616.55308.patch
Type: text/x-patch
Size: 1225 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160427/1c67852e/attachment.bin>