[PATCH] D19609: [ARM] Add support for long-call/short-call attribute

[Tim Northover via llvm-commits]

t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.

Hi Weiming,

I've got two issues with the current implementation:

First, I think this should be an attribute on the call-site rather than the callee. You could easily imagine (particularly in LTO situations targeting weird embedded memory layouts) mutually short-callable clusters of functions that need long-calls between those groups. If the attribute is fixed on the callee that's not going to work.

Second, I don't really think "target-features" is the place for this attribute. They're meant to affect the CodeGen of the function definition, not really what callees do with it as far as I can see.

Cheers.

Tim.


Repository:
  rL LLVM

http://reviews.llvm.org/D19609