[PATCH] D19515: [PGO] Prohibit the recording the function address if it's internal and COMDAT.

David Li via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 27 11:50:47 PDT 2016


davidxl added inline comments.

================
Comment at: test/Transforms/PGOProfile/comdat_internal.ll:16
@@ +15,3 @@
+; CHECK: @__profd__stdin__foo = private global { i64, i64, i64*, i8*, i8*, i32, [1 x i16] } { i64 -5640069336071256030, i64 12884901887, i64* getelementptr inbounds ([1 x i64], [1 x i64]* @__profc__stdin__foo, i32 0, i32 0), i8* null, i8* null, i32 1, [1 x i16] zeroinitializer }, section "__llvm_prf_data", comdat($__profv__stdin__foo), align 8
+; CHECK-NOT: @__profd__stdin__foo = private global { i64, i64, i64*, i8*, i8*, i32, [1 x i16] } { i64 -5640069336071256030, i64 12884901887, i64* getelementptr inbounds ([1 x i64], [1 x i64]* @__profc__stdin__foo, i32 0, i32 0), i8* bitcast (i32 ()* @foo to i8*), i8* null, i32 1, [1 x i16] zeroinitializer }, section "__llvm_prf_data", comdat($__profv__stdin__foo), align 8
+; CHECK: @__llvm_prf_nm = private constant [21 x i8] c"\0B\13x\DA\B3).I\C9\CC\B3\B3J\CB\CF\07\00\18a\04\1B", section "__llvm_prf_names"
----------------
I think you should relax the all the irrelevant substrings inside, and  just keep @__profd__stdin__foo   and @foo in the pattern.


http://reviews.llvm.org/D19515





More information about the llvm-commits mailing list