[PATCH] D19002: [LazyValueInfo] Fix for a nasty compile-time problem with questions

[Gerolf Hoflehner via llvm-commits]

> On Apr 26, 2016, at 8:11 PM, Gerolf Hoflehner via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> 
>> On Apr 26, 2016, at 7:34 PM, Philip Reames <listmail at philipreames.com> wrote:
>> 
>> reames added a comment.
>> 
>> In http://reviews.llvm.org/D19002#413301, @llvm-commits wrote:
>> 
>>> Yes, I had already kicked off a build with your patches. Unfortunately it does not (at least no significantly) fix the issue and the test case is still running (for about 30 min now). My fix brings CT down to 2 min on an RA compiler.
>> 
>> 
>> Surprising
>> 
>> Geoff, any chance you could share a test case?  I'd really like to understand why this is taking so long.
> Let me check. I certainly would like to see this in the compile-time test suite.
No, unfortunately. 
>> 
>> p.s. I think my earlier comment was unclear.  Assuming null pointer case in http://reviews.llvm.org/D18066 resolves your compile time problem, I plan on landing that one and not this one.  The effect should be roughly the same, but yours is a much deeper hack in the algorithm itself.
> FWIW, I’m not fond of this even when it fixed the issue.  The problem is in LVI so it should be fixed there.
>> 
>> 
>> http://reviews.llvm.org/D19002
>> 
>> 
>> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits