[PATCH] D19550: [InstCombine] Determine the result of a select based on a dominating condition.

Gerolf Hoflehner via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 27 10:43:18 PDT 2016


I sharpened the test case. 

-Gerolf

> On Apr 27, 2016, at 8:05 AM, Chad Rosier <mcrosier at codeaurora.org> wrote:
> 
> mcrosier added inline comments.
> 
> ================
> Comment at: test/Transforms/InstCombine/pr21210.ll:25
> @@ -24,3 @@
> -
> -; don't replace 'cond' by 'len' in a block ('b1') that dominates all uses
> -; of the select outside the home block ('bb'), but can be reached from the home
> ----------------
> I'm not exactly sure how to fix this test case so it exhibits the original problem as I don't fully understand the original problem.  Therefore, I move the test case into my new test case.  I can file a PR to make sure we follow up on this, but I'd prefer this issue not block this patch.
> 
> 
> http://reviews.llvm.org/D19550
> 
> 
> 



More information about the llvm-commits mailing list