[compiler-rt] r263160 - [Windows] Fix UnmapOrDie and MmapAlignedOrDie

[Reid Kleckner via llvm-commits]

On Wed, Apr 27, 2016 at 9:26 AM, Dmitry Vyukov <dvyukov at google.com> wrote:

> Hi,
>
> I had to restore the MEM_DECOMMIT part (r267730). Tsan relies on the
> old behavior.
> We can think of a better fix, but I needed to contain fire and update
> Go runtimes because commit window closes in few days and I will OOO
> the remaining days. So a delay here would mean 6 month delay in
> deployment of important fixes for Go.


I was not aware that we supported TSan on Windows. Does it have tests?

In the long term, TSan should not attempt to partially unmap a region.
Windows doesn't appear to support that. With your change, TSan on Windows
will essentially leak address space. I would really like to get back the
CHECK ASAP so that ASan doesn't accidentally end up with any similar leaks.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160427/510ba103/attachment.html>