[PATCH] D19550: [InstCombine] Determine the result of a select based on a dominating condition.

[Chad Rosier via llvm-commits]

mcrosier updated this revision to Diff 55229.
mcrosier added a comment.

Address Philip's comments:
-Added CHECK-NOT: select to all test cases
-Move the test case from pr21210.ll into select-implied.ll as I believe we all agree the test case is valid to transform and it isn't likely representative of the problem described in PR21210.
-Added a comment about why we might have a mismatch.  In the 30+ examples I reviewed all were cases where we were comparing a scalar cmp against a vector compare.  I imagine this case will occur in the future, so I somewhat prefer we keep the check in the callee unless you strongly object.


http://reviews.llvm.org/D19550

Files:
  lib/Analysis/ValueTracking.cpp
  lib/Transforms/InstCombine/InstCombineSelect.cpp
  test/Transforms/InstCombine/pr21210.ll
  test/Transforms/InstCombine/select-implied.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19550.55229.patch
Type: text/x-patch
Size: 5210 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160427/1dea70ee/attachment.bin>