[PATCH] D17729: [TargetInstrInfo] Add TargetInstrInfo interface isProfitableToBranch.

[James Molloy via llvm-commits]

jmolloy requested changes to this revision.
jmolloy added a comment.
This revision now requires changes to proceed.

Hi,

Sorry for how long it's taken - I only just saw this on my phab list.

I think this generally looks fine, but I don't see the need for isProfitableToBranch to be in TargetInstrInfo. You can simply put it in AArch64InstrInfo and query that directly in AArch64ConditionalCompares (much like is done in AArch64LdStOptimizer).

Cheers,

James


http://reviews.llvm.org/D17729