[PATCH] D19528: [ELF] - Implemented -z combrelocs/nocombreloc.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 27 04:56:16 PDT 2016


grimar added a comment.

In http://reviews.llvm.org/D19528#413335, @ruiu wrote:

> There are two ways of doing this. One way is, as you did, to sort symbols before writing it to the mmap'ed output. The other way is to write relocations to the buffer and sort the buffer as an array of RelTy. I think the latter is more efficient than the former because of better locality. Did you consider doing that way?


I did, but idea of sorting something that was already written did not look clean for me, I did not think
about possible perfomance win though. So, probably you're right, updated the patch.


http://reviews.llvm.org/D19528





More information about the llvm-commits mailing list