[PATCH] D19538: [ELF] - Some cleanup of Writer<ELFT>::createSections()

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 27 01:21:37 PDT 2016


grimar added a comment.

In http://reviews.llvm.org/D19538#413090, @ruiu wrote:

> I'm not sure if how this patch would work towards full linker script support. Can you describe your plan? Thanks!


There is no real plan yet, I am still investigating possible redesign of LS. This patch is just clean up as I noticed we are creating symbols, adding sections in different places/methods now,
what is in my opinion does not look clean when we have everything to localize that in one place. 
So patch does not directly related to linkerscript support except one moment:
void Writer<ELFT>::createSections() is used now not only for just creating some sections. It do a lot of things: updates symbol tables, scans relocations, finalizes the sections, something else probably. Some of these parts I hope can be reused after delegating create sections functionality to linkerscript. So I guess this function needs some cleanup and first step I would do is splitting it. But before doing that initial cleanup can be done and that is what patch do.


http://reviews.llvm.org/D19538





More information about the llvm-commits mailing list