[PATCH] D19470: [TLI] Unify LibFunc attribute inference. NFCI.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 23:09:28 PDT 2016


joker.eph accepted this revision.
joker.eph added a comment.
This revision is now accepted and ready to land.

Skimmed through, you remove a lot of lines, I like it ;)

LGTM.


================
Comment at: lib/Transforms/Utils/BuildLibCalls.cpp:742
@@ -71,1 +741,3 @@
+      M->getOrInsertFunction("strchr", I8Ptr, I8Ptr, I32Ty, nullptr);
+  inferLibFuncAttributes(*M->getFunction("strchr"), *TLI);
   CallInst *CI = B.CreateCall(
----------------
Looks like we could refactor all of these under something like `TLI::get(M, "strchr")`?


http://reviews.llvm.org/D19470





More information about the llvm-commits mailing list