[PATCH] D16085: [PPC] Add Subtarget feature slower ISEL targets. NFC

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 18:48:35 PDT 2016


hfinkel added a comment.

I think it would be best to make HasISEL a { Fast, Slow, No }-type enum. We can have separate feature strings for the llc command line, but otherwise it becomes difficult to make sure that the -misel -mno-isel options in Clang override things in the correct way. Please experiment with that -- that's the underlying design constraint.


================
Comment at: lib/Target/PowerPC/PPC.td:90
@@ -89,1 +89,3 @@
+def FeatureSlowISEL  : SubtargetFeature<"slowisel","HasSlowISEL", "true",
+                                        "The ISEL instruction is slow compared to a predicted branch">;
 def FeaturePOPCNTD   : SubtargetFeature<"popcntd","HasPOPCNTD", "true",
----------------
If this line is longer that 80 characters, please unindent it as with other similar lines.


http://reviews.llvm.org/D16085





More information about the llvm-commits mailing list