[PATCH] D17611: NFC. Introduce Value::isPointerDereferenceable

[Hal Finkel via llvm-commits]

hfinkel added inline comments.

================
Comment at: lib/Analysis/Loads.cpp:96
@@ -96,1 +95,3 @@
+  if (V->isPointerDereferenceable(CheckForNull)) {
+    assert(!CheckForNull && "don't check for non-null currently");
     return isAligned(V, Align, DL);
----------------
Leaving CheckForNull unimplemented seems prone to confusion, and this assert text does not say that this is not yet implemented. Do you just need to call isKnownNonNull? If so, do that.



http://reviews.llvm.org/D17611