[PATCH] D18592: [PowerPC] Back end improvements to vec_splat

[Hal Finkel via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

A couple of comments, otherwise LGTM.


================
Comment at: lib/Target/PowerPC/PPCVSXSwapRemoval.cpp:410
@@ -408,3 +409,3 @@
         // to adjust the source lane for the splat.  This is not yet
         // implemented.  When it is, we need to uncomment the following:
         SwapVector[VecIdx].IsSwappable = 1;
----------------
Looks like the "This is not yet implemented.  When it is, we need to uncomment the following:" part of this comment is out-dated. If so, please remove it.

================
Comment at: test/CodeGen/PowerPC/swaps-le-2.ll:90
@@ -89,3 +89,3 @@
 ; CHECK: lxvd2x
-; CHECK: vspltw {{[0-9]+}}, {{[0-9]+}}, 0
+; CHECK: xxspltw {{[0-9]+}}, {{[0-9]+}}, 0
 ; CHECK: stxvd2x
----------------
Please add a few more test cases for other index values. The space of bugs that might happen to continue to cause this index to be 0, but incorrectly compute others is pretty large.


Repository:
  rL LLVM

http://reviews.llvm.org/D18592