[PATCH] D19573: [ThinLTO] Refine fix to avoid renaming of uses in inline assembly.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 17:55:51 PDT 2016


joker.eph accepted this revision.
joker.eph added a comment.
This revision is now accepted and ready to land.

LGTM.
This is sketchy though, I'm fine with it on the short term, but anything "clever" using the summary will assume that if you have a summary you have all the informations in the summary for the module somehow, which this is breaking AFAICT.


================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:150
@@ +149,3 @@
+      for (auto &BB : F)
+        for (auto &I : BB)
+          if (const CallInst *CallI = dyn_cast<CallInst>(&I))
----------------
I think there is a shortcut ` for (auto &I : F.instructions())`


http://reviews.llvm.org/D19573





More information about the llvm-commits mailing list