[PATCH] D19570: [PDB] Parse module information from the DBI stream

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: include/llvm/DebugInfo/PDB/Raw/ModInfo.h:59
@@ +58,3 @@
+private:
+  const uint8_t *Bytes;
+};
----------------
Isn't it a bit confusing that this `Bytes` is actually bytes but `Bytes` in ModInfo is a ModInfoBytes object.

================
Comment at: include/llvm/DebugInfo/PDB/Raw/ModInfo.h:62
@@ +61,3 @@
+
+class ModInfoRange {
+public:
----------------
Can you use iterator_range<ModInfoStreamIterator> instead of defining a new class?

================
Comment at: lib/DebugInfo/PDB/Raw/ModInfo.cpp:49
@@ +48,3 @@
+  ulittle16_t NumFiles;      // Number of files contributing to this module
+  long *FileNameOffsets;     // array of [0..NumFiles) DBI name buffer offsets
+  ulittle32_t SrcFileNameNI; // Name Index for src file name
----------------
Do you mean ulittle32_t by long?


http://reviews.llvm.org/D19570