[PATCH] D19566: ELF: Merge UndefinedBitcode and UndefinedElf.

[Rui Ueyama via llvm-commits]

ruiu added a comment.

It's generally looking good.


================
Comment at: ELF/InputFiles.cpp:320
@@ -320,1 +319,3 @@
+      return new (Alloc)
+          Undefined(Sym->st_name, Sym->st_other, Sym->getType(), Sym->st_size);
     return new (Alloc) DefinedRegular<ELFT>(*Sym, Sec);
----------------
This may be a silly question, but I don't remember why we need to save st_size for undefined symbols. Are we using that information?


http://reviews.llvm.org/D19566