[PATCH] D19554: Add optimization bisect opt-in calls for PowerPC passes

[Hal Finkel via llvm-commits]

hfinkel added a comment.

> I selected the passes to be skipped based on the fact that they were not added at CodeGenOpt::None in PPCTargetMachine.cpp. Based on that criteria, I did not add opt-in calls to the following passes, which appear to be required:

> 

> PPCBSel

> PPCTOCRegDeps

> PPCTLSDynamicCall

> PPCVSXCopy

> PPCVSXFMAMutate


PPCVSXFMAMutate is an optimization, and should be included in the skippable passes.

> I also chose not to add the skip check to PPCCTRLoopsVerify, but I'm not certain about this one. This pass isn't run at -O0, so it meets the normal criteria for skipping, but since it is a verification function I decided not to add the skip check. If this is verifying that transformations were performed in PPCCTRLoops, which can be skipped, then there is a potential problem. If, on the other hand, it is simply verifying that the IR is legal following PPCCTRLoops then it should be fine to not skip it.


PPCCTRLoopsVerify is verifying work that PPCCTRLoops performed, and can only be skipped whenever PPCCTRLoops is skipped.


Repository:
  rL LLVM

http://reviews.llvm.org/D19554