[PATCH] D19522: Read discriminators correctly from object file.

[Dehao Chen via llvm-commits]

Unfortunately, we can't because I need to have two consecutive
instructions that are both from discriminator 1, but different lines
to trigger this bug. With your proposed change, the code sequence will
be:

line 4 discriminator 0
line 4 discriminator 1
line 5 discriminator 0
line 5 discriminator 1

But with my test case, the code sequence will be:

line 4 discriminator 0
line 5 discriminator 0
line 4 discriminator 1
line 5 discriminator 1

On Tue, Apr 26, 2016 at 12:46 PM, David Blaikie <dblaikie at gmail.com> wrote:
> dblaikie added inline comments.
>
> ================
> Comment at: test/DebugInfo/X86/discriminator2.ll:9
> @@ +8,3 @@
> +; #3 void baz() {
> +; #4   foo/*discriminator 1*/(bar(),
> +; #5       bar());bar()/*discriminator 1*/;
> ----------------
> Would it be simpler/sufficient to do this:
>
>   void f1();
>   void f2() {
>     f1(); f1();
>     f1(); f1();
>   }
>
> (with column info off? Or, to keep column info on, #define CALLS f1(); f1() and have the body of the function be:
>   CALLS;
>   CALLS;
> )
>
>
> http://reviews.llvm.org/D19522
>
>
>