[PATCH] D19538: [ELF] - Some cleanup of Writer<ELFT>::createSections()

[Rafael Ávila de Espíndola via llvm-commits]

rafael added inline comments.

================
Comment at: ELF/Writer.cpp:883
@@ +882,3 @@
+  // on the first page of the executable file when loaded into memory.
+  if (A == Out<ELFT>::Interp || B == Out<ELFT>::Interp)
+    return A == Out<ELFT>::Interp;
----------------
Please use the same structure we use for the other comparisons:

AIsFoo = ...;
BIsFoo = ...;
if (AIsFoo != BIsFoo)
 return ...;

I wonder if it wouldn't be nicer to just put Interp and BuildId at the start of the section list in addPredefinedSections and avoid having this special cases in the comparison function.



http://reviews.llvm.org/D19538