[PATCH] D19518: Add optimization bisect opt-in calls for NVPTX passes

[Andy Kaylor via llvm-commits]

andrew.w.kaylor added inline comments.

================
Comment at: lib/Target/NVPTX/NVPTXLowerKernelArgs.cpp:196
@@ -195,1 +195,3 @@
 bool NVPTXLowerKernelArgs::runOnFunction(Function &F) {
+  if (skipFunction(F))
+    return false;
----------------
jingyue wrote:
> handleByValParam is necessary for correctness, so NVPTXLowerKernelArgs can't be skipped unless we separate handleByValParam out to another pass. 
As far as I can tell, this pass is only ever added by NVPTXPassConfig::addAddressSpaceInferencePasses(), which is not called when the opt level is CodeGenOpt::None.

So if this pass is necessary there may be another problem that needs to be addressed regarding when and where the pass gets added.

I'll take the skip check out, but that's something you may want to look into.


Repository:
  rL LLVM

http://reviews.llvm.org/D19518