[PATCH] D19333: Move coverage related code into a separate library

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 11:14:43 PDT 2016


Easwaran Raman <eraman at google.com> writes:
> Justin, independent of the fact that this is really not a blocker for
> the profile summary change (as you point out in another thread), this
> seems like a desirable change to separate coverage from the rest of
> the ProfileData. Does that make sense?

I'm not really convinced that this is a desirable change, personally. It
seems like useless busywork to separate these two things, and if we are
going to make the claim that Coverage is independent/just a user of
ProfileData, why would it be nested inside the ProfileData subdirectory?

I won't block you from doing this, as having more smaller libraries
doesn't really hurt anything much and I guess it does solve your
immediate problem, but I do consider this just a hack to work around
whatever problems the current layout is causing you guys.


More information about the llvm-commits mailing list