[PATCH] D19515: [PGO] Prohibit the recording the function address if it's internal and COMDAT.

[Betul Buyukkurt via llvm-commits]

betulb added a comment.

Thanks for the test.


================
Comment at: lib/Transforms/Instrumentation/InstrProfiling.cpp:241
@@ -236,2 +240,3 @@
+    return false;
   // Check the linkage
   if (!F->hasLinkOnceLinkage() && !F->hasLocalLinkage() &&
----------------
I do not know yet much about COMDAT's. I need to read about them. Otherwise, the check is fine. But, I'd prefer it to be placed after line 244. There we reduce the linkages to check for to one of linkonce, local or available externally.  I'd also like to check if the same warning shows up for either of linkonce or available externally linkages.


http://reviews.llvm.org/D19515