[PATCH] D19522: Read discriminators correctly from object file.

[Dehao Chen via llvm-commits]

Original test source file added.

The IR is already minimal because I need to test discriminators from 2
lines, thus I need 4 function calls, 2 in each line.

Thanks,
Dehao

On Tue, Apr 26, 2016 at 10:32 AM, David Blaikie <dblaikie at gmail.com> wrote:
> Usually we try to reduce the source code before generating the IR test case
> (looks like this IR may've been hand reduced further? But I may be mistaken)
> for debug info tests & include the source in a comment at the top of the
> test so it's easy to understand the basic intent of the test case - since
> reconstructing the intent/semantics from the metadata is somewhat
> non-trivial.
>
> (also, sometimes we checkin binaries to test the dumper - we don't always,
> and I'm not suggesting it here, just mentioning it as a thought - sometimes
> we just treat the dumper as "golden" and assume we're just testing the LLVM
> IR/CodeGen behavior)
>
> - Dave
>
> On Tue, Apr 26, 2016 at 8:28 AM, Dehao Chen via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> danielcdh updated this revision to Diff 55008.
>> danielcdh added a comment.
>>
>> Add comment and reformat.
>>
>>
>> http://reviews.llvm.org/D19522
>>
>> Files:
>>   lib/DebugInfo/DWARF/DWARFDebugLine.cpp
>>   test/DebugInfo/X86/discriminator2.ll
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>