[PATCH] D19518: Add optimization bisect opt-in calls for NVPTX passes

[Justin Lebar via llvm-commits]

jlebar added a comment.

In http://reviews.llvm.org/D19518#412381, @jingyue wrote:

> Hi Andrew,
>
> What do you mean by "NVPTXPeephole can't be safely skipped"? I tried disabling it and then running all tests under test/CodeGen/NVPTX. None of the runs crash, and only local-stack-frame.ll failed because it verifies NVPTXPeephole indeed optimizes away redundant stack frame operations.




> Based on the description (not to mention the name) NVPTXPeephole seemed to me as if it **could** be safely skipped but it appears that it never is, so I did not add the opt-in call there.


(Emphasis mine.)  The issue AIUI is that NVPTXPeephole is enabled at -O0, so Andrew was conservatively assuming it was this way for a reason.


Repository:
  rL LLVM

http://reviews.llvm.org/D19518