[PATCH] D19527: LTOCodeGenerator: add linkonce to llvm.used when in "MustPreserve" set

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 09:35:03 PDT 2016


joker.eph marked 2 inline comments as done.
joker.eph added a comment.

Thanks for the comments.


================
Comment at: lib/LTO/LTOCodeGenerator.cpp:394
@@ +393,3 @@
+  if (ScopeRestrictionsDone)
+    return;
+
----------------
Yes, good catch. It turns out that the next variable declaration was unused, and was taken as body for the if block, which is why the code was still compiling...



http://reviews.llvm.org/D19527





More information about the llvm-commits mailing list