[PATCH] D19517: ELF: Treat IFunc definitions in DSOs as functions.

[Peter Collingbourne via llvm-commits]

On Tue, Apr 26, 2016 at 8:12 AM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> Interesting. I assume the dynamic linker then does all the work of
> calling the resolver function and setting the got entry.
>
> > ===================================================================
> > --- /dev/null
> > +++ test/ELF/Inputs/gnu-ifunc-gotpcrel.s
> > @@ -0,0 +1,5 @@
> > +.type foo STT_GNU_IFUNC
> > +.globl foo
> > +.type foo, @function
>
> Why do you need two .type directives?
>

I don't; removed. I was cargo culting from another test; I guess we don't
need the .type directives there either, I'll clean that up in a bit.

LGTM with that changed.
>

 r267566.

Thanks,
-- 
-- 
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160426/16da4cdc/attachment.html>