[PATCH] D19490: ELF: Teach section GC to also GC shared symbols.

[Peter Collingbourne via llvm-commits]

Thanks Rafael, I prefer the solution of setting IsUsed based on symbols.

Your attached patch LGTM as well. The code move I did in D19490 seems like
a useful independent cleanup, so I'll rebase it onto your change as an NFC.

Peter

On Tue, Apr 26, 2016 at 7:08 AM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> So, the fundamental problem had nothing to do with gc-sections.
>
> The problem was that we were setting IsUsedInRegularObj based on
> symbols but IsUsed based on relocations. I fixed that by setting
> IsUsed based on symbols. That matches what bfd and gold do and is
> simpler. IsUsed now just means that one of the symbol in that .so
> IsUsedInRegularObj.
>
> With that, the attached patch should fix the problem that is blocking
> adding version info, no?
>
> Cheers,
> Rafael
>



-- 
-- 
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160426/3616cbd1/attachment.html>