[PATCH] D19498: [scan-build] fix logic error warnings emitted on llvm code base

Apelete Seketeli via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 08:44:06 PDT 2016


apelete updated this revision to Diff 55012.
apelete marked 2 inline comments as done.
apelete added a comment.

[scan-build] fix logic error warnings emitted on llvm code base

Changes since last revision:

- lib/CodeGen/ScheduleDAGInstrs.cpp: remove assert and nullptr check on MachineInstr pointer to suppress analyzer warning: dereferencing MI pointer will induce a crash if it is null anyway,

- lib/Target/ARM/ARMFrameLowering.cpp: remove assert and nullptr check on RegScavenger pointer since ARMBaseRegisterInfo::requiresRegisterScavenging() always returns true,

- lib/Target/ARM/Thumb2SizeReduction.cpp: move assert closer to corresponding code block.


http://reviews.llvm.org/D19498

Files:
  lib/Bitcode/Writer/BitcodeWriter.cpp
  lib/CodeGen/ScheduleDAGInstrs.cpp
  lib/Target/ARM/ARMFrameLowering.cpp
  lib/Target/ARM/MCTargetDesc/ARMMachObjectWriter.cpp
  lib/Target/ARM/Thumb2SizeReduction.cpp
  lib/Target/Hexagon/HexagonCFGOptimizer.cpp
  lib/Target/Hexagon/RDFGraph.cpp
  lib/Target/X86/AsmParser/X86AsmParser.cpp
  lib/Transforms/Scalar/ScalarReplAggregates.cpp
  lib/Transforms/Scalar/StructurizeCFG.cpp
  lib/Transforms/Scalar/TailRecursionElimination.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19498.55012.patch
Type: text/x-patch
Size: 6725 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160426/56ea1494/attachment.bin>


More information about the llvm-commits mailing list