[PATCH] D19496: [ELF][MIPS] Handle GOT entries for all non-local symbols uniformly

[Simon Atanasyan via llvm-commits]

atanasyan added inline comments.

================
Comment at: ELF/OutputSections.h:139
@@ -136,1 +138,3 @@
+  };
+  std::vector<std::pair<EntryKind, SymbolBody *>> Entries;
   uint32_t TlsIndexOff = -1;
----------------
zatrazz wrote:
> On my TLS descriptor patch [1], after some discussion I changed the approach of using a vector of vectors to just define the required vectors instead (one for each type). I think using a vector for each type simplifies the code, since it won't require sorting in the finalize method.
> 
> [1] http://reviews.llvm.org/D18960
My motivation was to touch non-MIPS code as little as possible. In that case single vector is a good approach. But if MIPS is not the only architecture requires GOT entries "types" I would be happy to escape GOT sorting.

What is the state of your patch?


Repository:
  rL LLVM

http://reviews.llvm.org/D19496