[PATCH] D19490: ELF: Teach section GC to also GC shared symbols.

[Rafael Espíndola via llvm-commits]

I will take a look, but if the patch is fixing that it should be on the
test :-)
On Apr 25, 2016 10:19 PM, "Peter Collingbourne" <peter at pcc.me.uk> wrote:

> On Mon, Apr 25, 2016 at 7:13 PM, Rafael Espíndola <
> rafael.espindola at gmail.com> wrote:
>
>> > The whole point of this change is to make sure we don't have references
>> in
>> > the dynsym to symbols in unneeded DSOs. This is to avoid the scenario I
>> > mentioned in D19464 where we were emitting version requirements for DSOs
>> > that weren't in the needed list.
>> >
>> > Filtering the dynsym seemed like the best solution to this problem, as
>> it
>> > means we don't end up with unnecessary DSO references in the executable
>> that
>> > were created by unneeded sections.
>>
>> Would the attached patch have the desired effect? With it we consider
>> more DSOs needed, but the result should be consistent.
>>
>
> That's not enough to avoid that scenario. If I add --as-needed the DSO is
> removed from the needed list, but its symbols are still in the dynsym.
>
> Thanks,
> --
> --
> Peter
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160426/af3ae5a1/attachment.html>