[llvm] r267541 - Revert "ARM: put correct symbol index on indirect pointers in __thread_ptr."

[Daniel Sanders via llvm-commits]

Thanks. I was about to do the same thing to fix the MIPS buildbots.

> -----Original Message-----
> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On Behalf
> Of Renato Golin via llvm-commits
> Sent: 26 April 2016 11:02
> To: llvm-commits at lists.llvm.org
> Subject: [llvm] r267541 - Revert "ARM: put correct symbol index on indirect
> pointers in __thread_ptr."
> 
> Author: rengolin
> Date: Tue Apr 26 05:02:02 2016
> New Revision: 267541
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=267541&view=rev
> Log:
> Revert "ARM: put correct symbol index on indirect pointers in __thread_ptr."
> 
> This reverts commit r267488, as it broke some ARM buildbots.
> 
> Modified:
>     llvm/trunk/lib/MC/MachObjectWriter.cpp
>     llvm/trunk/test/MC/ARM/tls-directives.s
> 
> Modified: llvm/trunk/lib/MC/MachObjectWriter.cpp
> URL: http://llvm.org/viewvc/llvm-
> project/llvm/trunk/lib/MC/MachObjectWriter.cpp?rev=267541&r1=267540&
> r2=267541&view=diff
> ==========================================================
> ====================
> --- llvm/trunk/lib/MC/MachObjectWriter.cpp (original)
> +++ llvm/trunk/lib/MC/MachObjectWriter.cpp Tue Apr 26 05:02:02 2016
> @@ -471,8 +471,7 @@ void MachObjectWriter::bindIndirectSymbo
>           ie = Asm.indirect_symbol_end(); it != ie; ++it, ++IndirectIndex) {
>      const MCSectionMachO &Section = cast<MCSectionMachO>(*it-
> >Section);
> 
> -    if (Section.getType() != MachO::S_NON_LAZY_SYMBOL_POINTERS &&
> -        Section.getType() !=  MachO::S_THREAD_LOCAL_VARIABLE_POINTERS)
> +    if (Section.getType() != MachO::S_NON_LAZY_SYMBOL_POINTERS)
>        continue;
> 
>      // Initialize the section indirect symbol base, if necessary.
> 
> Modified: llvm/trunk/test/MC/ARM/tls-directives.s
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ARM/tls-
> directives.s?rev=267541&r1=267540&r2=267541&view=diff
> ==========================================================
> ====================
> --- llvm/trunk/test/MC/ARM/tls-directives.s (original)
> +++ llvm/trunk/test/MC/ARM/tls-directives.s Tue Apr 26 05:02:02 2016
> @@ -1,9 +1,5 @@
>  @ RUN: llvm-mc -triple thumbv7-apple-ios -filetype=obj -o %t %s
> -@ RUN: llvm-objdump -macho -p -indirect-symbols %t | FileCheck %s
> -
> -@ CHECK: Indirect symbols for (__DATA,__thread_ptr)
> -@ CHECK: 0x0000001c     5 _a
> -
> +@ RUN: llvm-objdump -p %t | FileCheck %s
> 
>  @ CHECK: sectname __thread_data
>  @ CHECK: segname __DATA
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits