[PATCH] D19487: [LV] Reallow interleaved load groups with gaps

silviu.baranga@arm.com via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 02:24:27 PDT 2016


sbaranga added a comment.

I might be missing something obvious, but why is TC >= Step if TC % Step is 0?

I think we also need to check that TC is not 0.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:2896
@@ +2895,3 @@
+  // step does not evenly divide the trip count, no adjustment is necessary
+  // since there will already be remainder iterations.
+  if (VF > 1 && Legal->requiresScalarIteration()) {
----------------
You're right, that should have been *not* 0, thanks!

The comment above needs to be updated.


http://reviews.llvm.org/D19487





More information about the llvm-commits mailing list