[compiler-rt] r267526 - Revert "[sanitizers] read/write page fault detection on mac."

[Mehdi Amini via llvm-commits]

Author: mehdi_amini
Date: Tue Apr 26 02:03:11 2016
New Revision: 267526

URL: http://llvm.org/viewvc/llvm-project?rev=267526&view=rev
Log:
Revert "[sanitizers] read/write page fault detection on mac."

This reverts commit r267477.
It broke our bots that enables the AArch64 backends, it seems that
this code is using a Darwin *X86 specific* field.

From: Mehdi Amini <mehdi.amini at apple.com>

Added:
    compiler-rt/trunk/test/asan/TestCases/Linux/segv_read_write.c
      - copied, changed from r267486, compiler-rt/trunk/test/asan/TestCases/Posix/segv_read_write.c
Removed:
    compiler-rt/trunk/test/asan/TestCases/Posix/segv_read_write.c
Modified:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_mac.cc

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_mac.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_mac.cc?rev=267526&r1=267525&r2=267526&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_mac.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_mac.cc Tue Apr 26 02:03:11 2016
@@ -500,8 +500,7 @@ void LogFullErrorReport(const char *buff
 }
 
 SignalContext::WriteFlag SignalContext::GetWriteFlag(void *context) {
-  ucontext_t *ucontext = static_cast<ucontext_t*>(context);
-  return ucontext->uc_mcontext->__es.__err & 2 /*T_PF_WRITE*/ ? WRITE : READ;
+  return UNKNOWN;  // FIXME: implement this.
 }
 
 void GetPcSpBp(void *context, uptr *pc, uptr *sp, uptr *bp) {

Copied: compiler-rt/trunk/test/asan/TestCases/Linux/segv_read_write.c (from r267486, compiler-rt/trunk/test/asan/TestCases/Posix/segv_read_write.c)
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/segv_read_write.c?p2=compiler-rt/trunk/test/asan/TestCases/Linux/segv_read_write.c&p1=compiler-rt/trunk/test/asan/TestCases/Posix/segv_read_write.c&r1=267486&r2=267526&rev=267526&view=diff
==============================================================================
    (empty)

Removed: compiler-rt/trunk/test/asan/TestCases/Posix/segv_read_write.c
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Posix/segv_read_write.c?rev=267525&view=auto
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/Posix/segv_read_write.c (original)
+++ compiler-rt/trunk/test/asan/TestCases/Posix/segv_read_write.c (removed)
@@ -1,26 +0,0 @@
-// RUN: %clangxx_asan -std=c++11 -O0 %s -o %t
-// RUN: not %run %t       2>&1 | FileCheck %s --check-prefix=READ
-// RUN: not %run %t write 2>&1 | FileCheck %s --check-prefix=WRITE
-// UNSUPPORTED: powerpc64,mips
-
-#include <sys/mman.h>
-
-static volatile int sink;
-__attribute__((noinline)) void Read(int *ptr) { sink = *ptr; }
-__attribute__((noinline)) void Write(int *ptr) { *ptr = 0; }
-int main(int argc, char **argv) {
-  // Writes to shadow are detected as reads from shadow gap (because of how the
-  // shadow mapping works). This is kinda hard to fix. Test a random address in
-  // the application part of the address space.
-  void *volatile p =
-      mmap(nullptr, 4096, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS, 0, 0);
-  munmap(p, 4096);
-  if (argc == 1)
-    Read((int *)p);
-  else
-    Write((int *)p);
-}
-// READ: AddressSanitizer: SEGV on unknown address
-// READ: The signal is caused by a READ memory access.
-// WRITE: AddressSanitizer: SEGV on unknown address
-// WRITE: The signal is caused by a WRITE memory access.