[PATCH] D19500: Parse and dump PDB DBI Stream Header Information

[Zachary Turner via llvm-commits]

But it's forward declared as a private nested class, so you can't reference
the inner class except from within the outer class
On Mon, Apr 25, 2016 at 11:40 PM David Majnemer <david.majnemer at gmail.com>
wrote:

> majnemer added inline comments.
>
> ================
> Comment at: lib/DebugInfo/PDB/Raw/PDBDbiStream.cpp:68
> @@ +67,3 @@
> +PDBDbiStream::PDBDbiStream(PDBFile &File) : Pdb(File), Stream(3, File) {
> +  static_assert(sizeof(HeaderInfo) == 64, "Invalid HeaderInfo size!");
> +}
> ----------------
> zturner wrote:
> > ruiu wrote:
> > > Can you write this outside of the constructor?
> > The class is forward declared as private in `PDBDbiStream.h`, so it's
> inaccessible outside the constructor.  I could declare it in the public
> section of the class, but it seemed more appropriate to be private.  I
> don't feel strongly either way, so let me know if you do.
> I don't think you need to stick it in the public section of the class, the
> static_assert could just follow immediately after the definition of
> HeaderInfo.
>
>
> http://reviews.llvm.org/D19500
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160426/179879c7/attachment.html>