[PATCH] D19386: [SPARC] [SSP] Add support for LOAD_STACK_GUARD.

[James Y Knight via llvm-commits]

jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.

Looks reasonable. OK, with requested comment addition.

(BTW: the current interface in llvm for overriding the behavior of SSP seems unnecessarily confusing, I hope that gets cleaned up at some point.)


================
Comment at: lib/Target/Sparc/SparcInstrInfo.cpp:500
@@ +499,3 @@
+           "Only Linux target is expected to contain LOAD_STACK_GUARD");
+    const int64_t Offset = Subtarget.is64Bit() ? 0x28 : 0x14;
+    MI->setDesc(get(Subtarget.is64Bit() ? SP::LDXri : SP::LDri));
----------------
Is there some ABI documentation that mentions these offsets? Or is this simply offsetof(tcbhead_t, stack_guard) from sysdeps/sparc/nptl/tls.h in glibc?

Can you add a comment here, whatever the source?


Repository:
  rL LLVM

http://reviews.llvm.org/D19386