[PATCH] D19464: ELF: Create .gnu.version and .gnu.version_r sections when linking against versioned DSOs.

[Peter Collingbourne via llvm-commits]

pcc added inline comments.

================
Comment at: ELF/InputFiles.cpp:438
@@ +437,3 @@
+  // Mapping from version identifiers to Elf_Verdef entries.
+  std::vector<const Elf_Verdef *> Verdefs(1);
+
----------------
ruiu wrote:
> Does this hide this->Verdefs?
It does. I've renamed the field to `VerdefMap`.

================
Comment at: ELF/OutputSections.cpp:1517
@@ +1516,3 @@
+    else
+      OutVersym->vs_index = 1;
+    ++OutVersym;
----------------
ruiu wrote:
> We should set 0, no?
I think it should be set to 1 because 0 is reserved for local symbols.


http://reviews.llvm.org/D19464