[PATCH] D19449: Add optimization bisect opt-in calls for ARM passes
Andy Kaylor via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 25 18:01:14 PDT 2016
andrew.w.kaylor added inline comments.
================
Comment at: llvm/trunk/lib/Target/ARM/Thumb2SizeReduction.cpp:1028
@@ -1027,2 +1027,3 @@
bool Thumb2SizeReduce::runOnMachineFunction(MachineFunction &MF) {
- if (PredicateFtor && !PredicateFtor(*MF.getFunction()))
+ if (skipFunction(*MF.getFunction()) ||
+ PredicateFtor && !PredicateFtor(*MF.getFunction()))
----------------
This was causing optnone-llc.ll to fail, so I'm taking it out, but it seems to me that this pass is definitely skippable. The optnone-llc.ll test fails because this pass is run at -O0. It seems to me that it shouldn't be, but I removed this to get the buildbot clean, since that seems like a higher priority.
Repository:
rL LLVM
http://reviews.llvm.org/D19449
More information about the llvm-commits
mailing list