[PATCH] D18972: [AMDGPU] Add basic relocation support (currently used for dwarf only)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 17:43:56 PDT 2016


arsenm added inline comments.

================
Comment at: include/llvm/Object/RelocVisitor.h:418
@@ +417,3 @@
+    int64_t Addend = getELFAddend(R);
+    uint32_t Res = (Value + Addend) & 0xFFFFFFFF;
+    return RelocToApply(Res, 4);
----------------
The & 0xFFFFFFFF is redundant with the truncate to uint32_t


http://reviews.llvm.org/D18972





More information about the llvm-commits mailing list