[PATCH] D19494: [ELF] Introduce --reproduce flag

[Rui Ueyama via llvm-commits]

On Mon, Apr 25, 2016 at 5:29 PM, Sean Silva <chisophugis at gmail.com> wrote:

> silvas added inline comments.
>
> ================
> Comment at: ELF/Driver.cpp:259
> @@ +258,3 @@
> +  for (unsigned I = 1, E = Args.size(); I < E; ++I)
> +    OS << " " << Args[I];
> +  OS << "\n";
> ----------------
> ruiu wrote:
> > silvas wrote:
> > > An argument might contain a space, so let's separate these by newlines
> instead.
> > > (an argument can technically contain a newline but I think that's
> sufficiently rare that we don't need to worry about that in a first patch.)
> > Pathname with spaces are also rare (except on Windows), no? An upside of
> writing all options in one line is you can (re-)execute the command just by
> passing the file to the shell.
> > Pathname with spaces are also rare (except on Windows), no?
>
> Exactly. Windows is one of our supported platforms.
>

Yeah, right. I would run lld only on Unix but I shouldn't have speculated
other people's use cases only from my use case.


> > An upside of writing all options in one line is you can (re-)execute the
> command just by passing the file to the shell.
>
> For now, let's go ahead with how Davide had it (one line). We can make
> this more robust in future patches.


Feel free to create a patch to separate it with newlines.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160425/65568d4b/attachment.html>