[PATCH] D19494: [ELF] Introduce --reproduce flag

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 17:19:51 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/Driver.cpp:259
@@ +258,3 @@
+  for (unsigned I = 1, E = Args.size(); I < E; ++I)
+    OS << " " << Args[I];
+  OS << "\n";
----------------
silvas wrote:
> An argument might contain a space, so let's separate these by newlines instead.
> (an argument can technically contain a newline but I think that's sufficiently rare that we don't need to worry about that in a first patch.)
Pathname with spaces are also rare (except on Windows), no? An upside of writing all options in one line is you can (re-)execute the command just by passing the file to the shell.


http://reviews.llvm.org/D19494





More information about the llvm-commits mailing list