[PATCH] D19494: [ELF] Introduce --reproduce flag

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 17:16:33 PDT 2016


ruiu added a comment.

LGTM with a nit.


================
Comment at: ELF/Driver.cpp:423-424
@@ -381,1 +422,4 @@
+
+  if (auto *Arg = Args.getLastArg(OPT_reproduce))
+    Config->Reproduce = Arg->getValue();
 }
----------------
Replace this with

  Config->Reproduce = getString(Args, OPT_reproduce, "");

and move to the group at line 350-356 (and sort the group).


http://reviews.llvm.org/D19494





More information about the llvm-commits mailing list