[PATCH] D19468: Disallow duplication of imported entities (improved implementation)

[David Blaikie via llvm-commits]

On Mon, Apr 25, 2016 at 2:25 PM, Amjad Aboud via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> aaboud added a comment.
>
> I am not much familiar with the AST part, but I assume there is reuse of
> previous generated DCL, even if it has same data.
>

What if we filter by cases where the decl == the canonical decl, and skip
any decl that's a redeclaration?


>
> Here is a small example that leads into duplication in AST DCLs.
> You may run the following command line:
>
>   clang -cc1 -ast-dump -o - -O0 TestIM.cpp
>
> TestIM.cpp
> ----------
>
>   #include "TestIM.h"
>   #include "TestIM.h"
>
>
>
> TestIM.h
> --------
>
>   namespace X {
>     typedef int MyINT_t;
>   }
>
>   namespace Y {
>     using X::MyINT_t;
>   }
>
>
> http://reviews.llvm.org/D19468
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160425/103b0810/attachment.html>