[PATCH] D19468: Disallow duplication of imported entities (improved implementation)

[David Blaikie via llvm-commits]

On Mon, Apr 25, 2016 at 10:57 AM, Adrian Prantl via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> aprantl added a comment.
>
> What’s the benefit to duplicating this code in every frontend? (Ok, having
> the code in DIBuilder is imposing extra work for frontends where duplicated
> entries are impossible.)
>

My position is this might not be work at all (visit using decls as they're
created so you don't have to revisit any of them in the first place) - and
structural deduplication seems more expensive than identity deduplication
that might be achievable in a frontend. (eg: get the canonical decl and use
a map/set of those with pointer identity rather than structural identity)


>
>
> http://reviews.llvm.org/D19468
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160425/1ce1a083/attachment.html>