[PATCH] D19500: Parse and dump PDB DBI Stream Header Information

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: lib/DebugInfo/PDB/Raw/PDBDbiStream.cpp:1
@@ +1,2 @@
+//===- PDBDbiStream.cpp - PDB Dbi Stream (Stream 3) Access ------*- C++ -*-===//
+//
----------------
You can remove `*- C== -*` since this file has .cpp file extension.

================
Comment at: lib/DebugInfo/PDB/Raw/PDBDbiStream.cpp:44
@@ +43,3 @@
+struct PDBDbiStream::HeaderInfo {
+  support::ulittle32_t VersionSignature;
+  support::ulittle32_t VersionHeader;
----------------
Do you want to add `using namespace llvm::support`?

================
Comment at: lib/DebugInfo/PDB/Raw/PDBDbiStream.cpp:68
@@ +67,3 @@
+PDBDbiStream::PDBDbiStream(PDBFile &File) : Pdb(File), Stream(3, File) {
+  static_assert(sizeof(HeaderInfo) == 64, "Invalid HeaderInfo size!");
+}
----------------
Can you write this outside of the constructor?


http://reviews.llvm.org/D19500