[PATCH] D19448: Introducing LLVMMetadataRef

Amaury SECHET via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 15:30:53 PDT 2016


deadalnix added inline comments.

================
Comment at: lib/IR/Core.cpp:818
@@ +817,3 @@
+LLVMValueRef LLVMMetadataAsValue(LLVMContextRef C, LLVMMetadataRef MD) {
+  return wrap(MetadataAsValue::get(*unwrap(C), unwrap(MD)));
+}
----------------
Wallbraker wrote:
> Shouldn't we do a similar smart unwrap that we do with ValueAsMetadata, turning constants into real constants?
This is unwrapping constants internally already.


http://reviews.llvm.org/D19448





More information about the llvm-commits mailing list