[PATCH] D19492: [LVI] Infer local facts from unary expressions

[Chad Rosier via llvm-commits]

mcrosier added inline comments.

================
Comment at: lib/Analysis/LazyValueInfo.cpp:1011
@@ -1008,2 +1010,3 @@
     if (pushBlockValue(std::make_pair(BB, BBI->getOperand(0))))
+      // More work to do before applying this transfer rule
       return false;
----------------
Please add a period.

When writing comments, write them as English prose, which means they should use proper capitalization, punctuation, etc.

================
Comment at: test/Transforms/CorrelatedValuePropagation/basic.ll:420
@@ +419,3 @@
+; TODO: missed optimization
+; Make sure we exercise non-integer inputs to unary operators (i.e. crash check)
+define i1 @bitcast_unknown(float %a) {
----------------
Please add a period.


http://reviews.llvm.org/D19492