[PATCH] D19464: ELF: Create .gnu.version and .gnu.version_r sections when linking against versioned DSOs.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Symbols.h:350-356
@@ -347,1 +349,9 @@
 
+  // This field is initially a pointer to the symbol's version definition. As
+  // symbols are added to the version table, this field is replaced with the
+  // version identifier to be stored in .gnu.version in the output file.
+  union {
+    const Elf_Verdef *Verdef;
+    uint16_t VersionId;
+  };
+
----------------
Ah, sorry, I intended to add comment here. Instead of adding uncooked Verdef, why don't you add the version string here?


http://reviews.llvm.org/D19464